Thanks for the PR.

How about the following compromise:

depends 'apt', '>= 2.0.0'
depends 'yum', '>= 3.0.0'        
depends 'windows', '>= 1.0.0'        

edited ^^^

I'm worried that other cookbooks that pessimistic lock to these older major versions would be broken. The windows one in particular would cause issues with Chef 11.

I am not aware of many people using Chef 11 anymore, perhaps bump the cookbook to version 2.x to signify the large jump in low level dependencies?

Ok, sold! Please remove the windows cookbook dependency (because it should no longer be needed in Chef 12) and add chef_version '>= 12' to metadata.rb as well. If there are warnings about windows_package, I think changing windows_package to just package on line https://github.com/dhoer/chef-perforce/blob/c00965bf149edda36623100e235d6792cc611437/recipes/default.rb#L37 might fix it .

Ok give me till Monday/Tuesday to do this.

No problem. I think you can ditch all of the cookbook dependencies. Apt_repository was released in 12.9 Chef chef/chef#4782 and yum_repository is also available in Chef as well. There is even chefspec examples: https://github.com/sethvargo/chefspec/tree/master/examples.

After doing some research, require Chef 12.6+ (What Chef recommends for its windows package resource), drop the windows cookbook, but keep both the apt and yum cookbooks. Yum_repository was introduced in Chef 12.14, but it is not a stable chefdk release yet.

I'm afraid I lead you astray, windows_package should remain windows package.

Updated

2.0 released, thanks again for the PR.